[flang][runtime] Underflow real input to -0. when negative #82443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the result of real input editing underflows to zero, return -0. when the input field had a minus sign.
vdonaldson
approved these changes
Feb 21, 2024
luporl
added a commit
to luporl/llvm-project
that referenced
this pull request
Mar 8, 2024
Select POSIX 2008 standard to avoid including Darwin extensions. Otherwise, Darwin's math.h header defines HUGE, which conflicts with Flang's HUGE function. This is a temporary build fix. More permanent solutions would be to rename Flang's HUGE or to define _POSIX_C_SOURCE for Flang as a whole. This started happening after 4762c65 (llvm#82443), that added the "utility" include, which seems to include "math.h".
luporl
added a commit
to luporl/llvm-project
that referenced
this pull request
Mar 8, 2024
Select POSIX 2008 standard to avoid including Darwin extensions. Otherwise, Darwin's math.h header defines HUGE, which conflicts with Flang's HUGE function. This started happening after 4762c65 (llvm#82443), that added the "utility" include, which seems to include "math.h".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the result of real input editing underflows to zero, return -0. when the input field had a minus sign.